feat: new-user default posture — egress allowed by default, init template fixed - #236
Merged
Merged
Conversation
…it template no longer forces global prompt - defaultActions: NetworkEgress prompt → allow (safe/local_write already allow) - globalConfigTemplate: drop 'action': 'prompt' global override (it downgraded even safe/local_write to prompting — the biggest out-of-box friction bug) and the redundant network_egress pin - tests: pinned contracts updated RED-first (egress default, template has no global override); approver/audit/allowlist tests re-pinned on system_write or explicit egress config so their intent survives the default change - docs: CONFIG.md class table + scheduler note, SECURITY.md default posture
…atch/web_search (shell egress unguarded), fix CLI.md example template, MIGRATION sub-agent note
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
odek | 0c4dea2 | Commit Preview URL Branch Preview URL |
Sep 13 2026, 05:43 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New-user default posture:
network_egressallows by default, andodek init --globalno longer writes the global"action": "prompt"override that downgraded evensafe/local_writeto prompting. Red-first tests, adversarially reviewed, docs updated.What changed
defaultActions:NetworkEgress: Prompt → Allow—safeandlocal_writealready allowed; egress joins them for a friction-free start.system_write/persistence/unread_exec/code_execution/installstill prompt;destructive/blocked/unknownstill deny."action": "prompt"(global override that neutered per-class defaults — every command prompted,unknownweakened deny→prompt) and the redundantnetwork_egresspin. Existing user configs untouched (explicitactionstill wins).TestInitTemplate_NoGlobalDangerousActionOverride+ egress default pin; 4 tests that leaned on egress-prompt re-pinned (explicit config orsystem_write) preserving their original intent.Review findings (adversarial, all addressed)
SECURITY.md overclaimed SSRF coverage for shell egress→ claim scopedschedules.dangerous.classes); flooring it is a posture decision left to the operator, flagged hereCLI.md example showed old template→ fixedVerified: browser/web_search/http_batch consult ActionFor then SSRF-guard (action-independent); Telegram media approval and sub-agent lockdown unaffected; re-pinned tests non-vacuous; template field remains valid (
NoDeadOrMissingKeysfine); localConfigTemplate irrelevant (project dangerous ignored).Test evidence
internal/danger,internal/config,internal/loop,internal/mcpclientgreen; cmd/odek template/pillar/danger-desc tests green. Interactive tail covered by CI.